Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 214: self.log.debug("Updating stale PUUID LV tag from %s to %s for " Line 215: "volume %s", tagParent, metaParent, Line 216: child.volUUID) Line 217: child.setParentTag(metaParent) Line 218: self.recheckIfLeaf() I am not thrilled to have this in the loop. We probably want to check this only once and only if we changed at least one parent tag. Line 219: Line 220: if not force: Line 221: self.validateDelete() Line 222: -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
