Gilad Chaplik has posted comments on this change. Change subject: adding API methods for blkio limits MOM integration ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28547/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4604: except libvirt.libvirtError as e: Line 4605: return self._reportError(msg=e.message, entity='vcpu period') Line 4606: return {'status': doneCode} Line 4607: Line 4608: def setBlkioTuneMap(self, dev, blkIoTuneMap): missing validate device in vm Line 4609: self._validateIoTuneParams(self, blkIoTuneMap) Line 4610: Line 4611: try: Line 4612: self._dom.setBlockIoTune(dev, blkIoTuneMap, libvirt.VIR_DOMAIN_AFFECT_CURRENT) Line 4619: def _checkIoTuneInvalidParams(self, blkIoTuneMap): Line 4620: validKeys = set(('total_bytes_sec', 'read_bytes_sec', Line 4621: 'write_bytes_sec', 'total_iops_sec', Line 4622: 'write_iops_sec', 'read_iops_sec')) Line 4623: paramKeys = set(blkIoTuneMap) clean WS next patchset Line 4624: Line 4625: invalidParams = paramKeys - validKeys Line 4626: if invalidParams: Line 4627: invalidParamNames = ', '.join(invalidParams) -- To view, visit http://gerrit.ovirt.org/28547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
