Dan Kenigsberg has posted comments on this change. Change subject: LiveMerge: fix regex for qemu-img info ......................................................................
Patch Set 3: Code-Review+1 (1 comment) After you have honorably added qemuimgTests in the previous patch, adding a case for absolute-path backing file would be a nice topping. http://gerrit.ovirt.org/#/c/26633/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 37: 'format': re.compile("^file format: (?P<value>\w+)$"), Line 38: 'virtualsize': re.compile("^virtual size: " Line 39: "[\d.]+[KMGT] \((?P<value>\d+) bytes\)$"), Line 40: 'clustersize': re.compile("^cluster_size: (?P<value>\d+)$"), Line 41: 'backingfile': re.compile("^backing file: (?P<value>\S+)"), It's not a real problem for vdsm, but I dislike assuming things about valid characters in the the path. However, since the original code already assumes that " (actual path" does not appear in the path, and since qemu-img does not provide 100% safe path encoding, I suppose we can take this. Line 42: 'offset': re.compile("^Image end offset: (?P<value>\d+)$"), Line 43: } Line 44: Line 45: -- To view, visit http://gerrit.ovirt.org/26633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c51f544cba3daa5a93f0502385d40db9dbddc63 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
