Dan Kenigsberg has submitted this change and it was merged. Change subject: LiveMerge: Add support for deleting merged volumes ......................................................................
LiveMerge: Add support for deleting merged volumes Once a live merge has completed the merged volumes that have previously been unlinked from the chain need to be deleted. We can use the existing deleteVolume verb with one minor change for block volumes. When deleting a live-merged volume, its former child may have a stale LV tag pointing back to this volume. This occurs because an HSM host resolves the block job completion event and can only update the parent UUID in the storage domain's metadata LV (not in the LV Tags). In this special case, we sync the LV tag of the child to match the metadata LV prior to validating the delete operation. Also, don't validate deletes in hsm.py since we already perform validation in the volume-specific implementations. Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/26768 Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> --- M vdsm/storage/blockVolume.py M vdsm/storage/hsm.py 2 files changed, 34 insertions(+), 7 deletions(-) Approvals: Adam Litke: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
