Federico Simoncelli has posted comments on this change. Change subject: sparsify: integrating virt-sparsify into vdsm ......................................................................
Patch Set 3: (4 comments) Mostly ok, thanks! http://gerrit.ovirt.org/#/c/28328/3/configure.ac File configure.ac: Line 246: AC_PATH_PROG([TUNE2FS_PATH], [tune2fs], [/sbin/tune2fs]) Line 247: AC_PATH_PROG([UDEVADM_PATH], [udevadm], [/sbin/udevadm]) Line 248: AC_PATH_PROG([UMOUNT_PATH], [umount], [/bin/umount]) Line 249: AC_PATH_PROG([UNPERSIST_PATH], [unpersist], [/usr/sbin/unpersist]) Line 250: AC_PATH_PROG([VIRTSPARSIFY_PATH], [virt-sparsify], [/usr/bin/virt-sparsify]) > No. Will remove. Right we already have: Requires: libguestfs-tools-c This part here is correct anyway, don't change it. Line 251: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget]) Line 252: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum]) Line 253: Line 254: # Keep sorted http://gerrit.ovirt.org/#/c/28328/3/vdsm/storage/image.py File vdsm/storage/image.py: Line 1229: """ Line 1230: Sparsify the 'srcVol' volume to 'dstVol' volume using libguestfs Line 1231: virt-sparsify Line 1232: """ Line 1233: log.debug('(virtSparsify): virt-sparsify %s %s START' % (srcVol, dstVol)) This kind of logging format is deprecated. You can drop it. Line 1234: Line 1235: cmd = [constants.EXT_VIRTSPARSIFY, srcVol, dstVol] Line 1236: (rc, out, err) = misc.watchCmd(cmd, stop=stop) Line 1237: Line 1234: Line 1235: cmd = [constants.EXT_VIRTSPARSIFY, srcVol, dstVol] Line 1236: (rc, out, err) = misc.watchCmd(cmd, stop=stop) Line 1237: Line 1238: if not rc: Drop this logging as well. Line 1239: log.debug('(virtSparsify): virt-sparsify %s %s DONE' Line 1240: % (srcVol, dstVol)) Line 1241: else: Line 1242: log.error('(virtSparsify): virt-sparsify %s %s FAILED' Line 1241: else: Line 1242: log.error('(virtSparsify): virt-sparsify %s %s FAILED' Line 1243: % (srcVol, dstVol)) Line 1244: Line 1245: return (rc, out, err) Check what qemuimg.py does. It raises a specific exception instead of returning rc, out and err. -- To view, visit http://gerrit.ovirt.org/28328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bd2b4b6d45781fa27a128dd68d14b7561d0901 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Utkarsh Singh <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Utkarsh Singh <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
