Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Refactor drive extension ......................................................................
virt: Refactor drive extension A future live merge patch will require the ability to send extend messages for internal drive volumes. To make this easier, refactor the code a bit: - Introduce a function that selects candidate volumes - Introduce a function that chooses whether a volume should be extended - getNextVolumeSize should take the current size as a parameter rather than assuming it is self.apparentsize - Pass volumeID explicitly to the extension functions since it may differ from drive.volumeID - When validating a resize, only update the drive if the leaf volume was extended Change-Id: I62b0941958618884aea67c7929ae3822a694ff5b Signed-off-by: Adam Litke <[email protected]> Reviewed-on: http://gerrit.ovirt.org/28533 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 72 insertions(+), 49 deletions(-) Approvals: Adam Litke: Verified Federico Simoncelli: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62b0941958618884aea67c7929ae3822a694ff5b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
