Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: add gateway reporting to all devices ......................................................................
Patch Set 1: Verified+1 Ran the functional tests: rhel65_01 tests (b38ff07) # ./run_tests_local.sh -x functional/networkTests.py NetworkTest testAddDelBondedNetwork(kwargs=False) OK testAddDelBondedNetwork(kwargs=True) OK testAddDelNetwork(kwargs=False) OK testAddDelNetwork(kwargs=True) OK testAddNetworkBondWithManyVlans(kwargs=False) OK testAddNetworkBondWithManyVlans(kwargs=True) OK testAddNetworkManyVlans(kwargs=False) OK testAddNetworkManyVlans(kwargs=True) OK testAddNetworkVlan(kwargs=False) OK testAddNetworkVlan(kwargs=True) OK testAddNetworkVlanBond(kwargs=False) OK testAddNetworkVlanBond(kwargs=True) OK testAddVlanedBridgeless OK testAddVlanedBridgeless_oneCommand OK testAfterNetworkSetupHook OK testBeforeNetworkSetupHook OK testBondHwAddress(kwargs=False) OK testBondHwAddress(kwargs=True) OK testBrokenBridgelessNetReplacement OK testDelNetworkBondAccumulation OK testDelNetworkWithMTU(kwargs=False) OK testDelNetworkWithMTU(kwargs=True) OK testDelWithoutAdd(kwargs=False) OK testDelWithoutAdd(kwargs=True) OK testDhclientLeases(kwargs='default') OK testDhclientLeases(kwargs='local') OK testEditWithoutAdd(kwargs=False) OK testEditWithoutAdd(kwargs=True) OK testFailWithInvalidBondingName(kwargs=False) OK testFailWithInvalidBondingName(kwargs=True) OK testFailWithInvalidBridgeName OK testFailWithInvalidIpConfig OK testFailWithInvalidNic(kwargs=False) OK testFailWithInvalidNic(kwargs=True) OK testFailWithInvalidParams(kwargs=False) OK testFailWithInvalidParams(kwargs=True) OK testGetRouteDeviceTo OK testHonorBlockingDhcp OK testIPv6ConfigNetwork OK testIpLinkWrapper OK testLowerMtuDoesNotOverride OK testNoBridgeLeftovers OK testQosNetwork OK testRedefineBondedNetworkIPs OK testRouteExists OK testRuleExists OK testSafeNetworkConfig(kwargs=False) OK testSafeNetworkConfig(kwargs=True) OK testSetupNetworksAddBadParams(bridged=False) OK testSetupNetworksAddBadParams(bridged=True) OK testSetupNetworksAddBondWithManyVlans(kwargs=False) OK testSetupNetworksAddBondWithManyVlans(kwargs=True) OK testSetupNetworksAddDelBondedNetwork(kwargs=False) OK testSetupNetworksAddDelBondedNetwork(kwargs=True) OK testSetupNetworksAddDelDhcp(kwargs=False) OK testSetupNetworksAddDelDhcp(kwargs=True) OK testSetupNetworksAddManyVlans(kwargs=False) OK testSetupNetworksAddManyVlans(kwargs=True) OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK testSetupNetworksAddOverExistingBond(kwargs=False) OK testSetupNetworksAddOverExistingBond(kwargs=True) OK testSetupNetworksAddVlan(kwargs=False) OK testSetupNetworksAddVlan(kwargs=True) SKIP: This test is known to break until initscripts-9.03.41-1.el6 is released to fix https://bugzilla.redhat.com/1086897 testSetupNetworksConvertVlanNetBridgeness OK testSetupNetworksDelOneOfBondNets OK testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=False)OK testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=True)OK testSetupNetworksMtus(kwargs=False) OK testSetupNetworksMtus(kwargs=True) OK testSetupNetworksMultiMTUsOverBond(kwargs=False) OK testSetupNetworksMultiMTUsOverBond(kwargs=True) OK testSetupNetworksMultiMTUsOverNic(kwargs=False) OK testSetupNetworksMultiMTUsOverNic(kwargs=True) OK testSetupNetworksNetCompatibilityBondSingleBridge OK testSetupNetworksNetCompatibilityBondSingleBridgeless OK testSetupNetworksNetCompatibilityNicSingleBridge OK testSetupNetworksNetCompatibilityNicSingleBridgeless OK testSetupNetworksNicless OK testSetupNetworksNiclessBridgeless OK testSetupNetworksOverDhcpIface OK testSetupNetworksResizeBond(kwargs=False) OK testSetupNetworksResizeBond(kwargs=True) OK testSetupNetworksStableBond(kwargs=False) OK testSetupNetworksStableBond(kwargs=True) OK testStaticSourceRouting(kwargs=False) OK testStaticSourceRouting(kwargs=True) OK testTwiceAdd(kwargs=False) OK testTwiceAdd(kwargs=True) OK testVolatileConfig(kwargs=False) OK testVolatileConfig(kwargs=True) OK ---------------------------------------------------------------------- Ran 93 tests in 449.453s OK (SKIP=1) rhel65_01 tests (b38ff07) # and tested the ipv4 gateway reporting by asking vdsCapabilites and checking that my nic reports it's configured gateway: nics = {'eth0': {'addr': '10.34.61.70', 'cfg': {'BOOTPROTO': 'dhcp', 'DEVICE': 'eth0', 'HWADDR': '00:1A:4A:0C:87:7F', 'IPV6INIT': 'no', 'MTU': '1500', 'NM_CONTROLLED': 'yes', 'ONBOOT': 'yes', 'TYPE': 'Ethernet', 'UUID': '9204f9ef-1994-4a4b-9bb9-ebef74bdddb3'}, 'gateway': '10.34.63.254', 'hwaddr': '00:1a:4a:0c:87:7f', 'ipv4addrs': ['10.34.61.70/22'], 'ipv6addrs': ['fe80::21a:4aff:fe0c:877f/64'], 'ipv6gateway': '::', 'mtu': '1500', 'netmask': '255.255.252.0', 'speed': 0}, Finally tried adding, in a table different than the main one, a gateway and made sure that it was not reported by mistake. -- To view, visit http://gerrit.ovirt.org/28704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dc4730214efa9eaba8425c3bf4842441b97084f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches