Martin Sivák has uploaded a new change for review. Change subject: Add IO tunables support to updateVmPolicy ......................................................................
Add IO tunables support to updateVmPolicy Change-Id: I4ed108fbb2bf9d9af80577b2905242bf9f8c4221 Signed-off-by: Martin Sivak <[email protected]> --- M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/vm.py 2 files changed, 33 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/28715/1 diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json index 1dbb5f7..9bd0d21 100644 --- a/vdsm/rpc/vdsmapi-schema.json +++ b/vdsm/rpc/vdsmapi-schema.json @@ -2324,6 +2324,26 @@ 'ioTune': 'VmDiskDeviceIoTuneParams'}} ## +# @VmDiskDeviceTuneLimits: +# +# Extra parameters for VM disk devices. +# +# @name: #optional The name of the taget device +# +# @path: #optional The path of the taget device +# +# @guaranteed: IO tune parameters - guranteed values +# +# @maximum: IO tune parameters - the hard limits +# +# Since: 4.15.0 +## +{'type': 'VmDiskDeviceTuneLimits', + 'data': {'*name': 'str', '*path': 'str', + 'guaranteed': 'VmDiskDeviceIoTuneParams', + 'maximum': 'VmDiskDeviceIoTuneParams'}} + +## # @VmDiskDeviceVolumeChainEntry: # # Identifies one volume in a VM disk device volume chain. @@ -7523,8 +7543,11 @@ # # @vmID: The UUID of the VM # -# @vcpuLimit: vcpu limit to set - the value is a percentage representation -# of the amount of cpu from the Host that the VM can consume +# @vcpuLimit: #optional vcpu limit to set - the value is a percentage +# representation of the amount of cpu from the Host that +# the VM can consume +# +# @ioTune: #optional list of ioTune limits to set # # Returns: # The VM definition, as updated @@ -7532,4 +7555,4 @@ # Since: 4.15.0 ## {'command': {'class': 'VM', 'name': 'updateVmPolicy'}, - 'data': {'vmID': 'UUID', 'vcpuLimit': 'int'}} + 'data': {'vmID': 'UUID', '*vcpuLimit': 'int', '*ioTune': ['VmDiskDeviceTuneLimits']}} diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index a4e5c2a..49e6f70 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -3671,6 +3671,7 @@ Supported properties are: vcpuLimit - the CPU usage hard limit + ioTune - the IO limits In the case not all properties are provided, the missing properties' setting will be left intact. @@ -3714,6 +3715,12 @@ else: del params['vcpuLimit'] + if 'ioTune' in params: + for limit_object in params['ioTune']: + # TODO implementation + pass + del params['ioTune'] + # Check remaining fields in params and report the list of unsupported # params to the log -- To view, visit http://gerrit.ovirt.org/28715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ed108fbb2bf9d9af80577b2905242bf9f8c4221 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
