Nir Soffer has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/25978/20/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 340: monitorThread.start() Line 341: try: Line 342: yield monitorThread Line 343: finally: Line 344: monitorThread.stop() This can be much more useful as general utility for things that you can start and stop. @contextmanager def running(thing): thing.start() try: yield finally: thing.stop() Usage: self._thread = FooThread() with running(self._thread): do staff and some more Line 345: Line 346: Line 347: class MonitorThread(threading.Thread): Line 348: _MONITOR_TICK = 1.0 # unit: seconds -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
