Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28700/3/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 820: else: Line 821: continue Line 822: info.update(_devinfo(dev, ipaddrs)) Line 823: if dev.isBOND(): Line 824: _bondOptsForIfcfg(info) Here you are passing the info dictionary of all devices and in _bondOptsForIfcfg it expects the info dictionary of a single device. In any case, I really preferred the previous version of the patch. I feel that this bonOptsIfcfg addendum does not belong to the same patch. Line 825: Line 826: _cfgBootprotoCompat(d) Line 827: Line 828: return d -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches