Nir Soffer has posted comments on this change. Change subject: domainMonitor: Extract domain monitoring methods ......................................................................
Patch Set 2: -Code-Review (2 comments) http://gerrit.ovirt.org/#/c/27714/2/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 304: # Managing host id Line 305: Line 306: def _shouldAcquireHostId(self): Line 307: # An ISO domain can be shared by multiple pools Line 308: return (not self.isIsoDomain and Next patch: - self.isIsoDoamin is False - we should try to acquire the host id if we don't know about isIsoDoamin. Line 309: self.nextStatus.valid and Line 310: self.nextStatus.hasHostId is False) Line 311: Line 312: def _shouldReleaseHostId(self): Line 311: Line 312: def _shouldReleaseHostId(self): Line 313: # If this is an ISO domain we didn't acquire the host id and releasing Line 314: # it is superfluous. Line 315: return self.domain and not self.isIsoDomain Next patch: - Remove the domain check - self.isIsoDoamin is False Line 316: Line 317: def _acquireHostId(self): Line 318: try: Line 319: self.domain.acquireHostId(self.hostId, async=True) -- To view, visit http://gerrit.ovirt.org/27714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
