Nir Soffer has posted comments on this change. Change subject: misc: Fix possible deadlock when entering sampling method ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28612/1/vdsm/storage/misc.py File vdsm/storage/misc.py: Line 733: self.__funcParent = self.__func.__module__ Line 734: Line 735: self._log.debug("Trying to enter sampling method (%s.%s)", Line 736: self.__funcParent, self.__funcName) Line 737: if self.__barrier.enter(): > why not to use with statement as you did in http://gerrit.ovirt.org/#/c/286 It is not required to fix this issue. I both patches will be accepted I'll rebase. Line 738: try: Line 739: self._log.debug("Got in to sampling method") Line 740: self.__lastResult = self.__func(*args, **kwargs) Line 741: finally: -- To view, visit http://gerrit.ovirt.org/28612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4b5ce467ed07a3ba787687c7caa9db4c765ef08 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
