Nir Soffer has posted comments on this change. Change subject: vdsm: fixing optional parameters ......................................................................
Patch Set 1: (1 comment) Looks good but needs a better commit message. http://gerrit.ovirt.org/#/c/28857/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-06-17 16:07:32 +0200 Line 6: Line 7: vdsm: fixing optional parameters Line 8: Line 9: Adding names for optional parameters. What missing is why this is important - you should not assume the order of optional arguments. Line 10: Line 11: Line 12: Change-Id: I2649a7d3a8a1e98268356833ad9bc6a4eaed1715 -- To view, visit http://gerrit.ovirt.org/28857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2649a7d3a8a1e98268356833ad9bc6a4eaed1715 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
