Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27481/8//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-05-28 15:35:21 +0300 Line 6: Line 7: vdsm-tool: Add logging and verbosity flags Line 8: Line 9: Added -l/--logfile, -v/--verbose flags to vdsm-tool to control the log. > Add the append here please Done Line 10: Line 11: Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43 http://gerrit.ovirt.org/#/c/27481/8/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line 146: Line 147: if verbose: Line 148: level = logging.DEBUG Line 149: else: Line 150: level = logging.WARNING > But getopt doesn't support this :( Done, with getopt! Line 151: Line 152: if log_file is not None: Line 153: handler = logging.FileHandler(log_file, mode=(append and 'a' or 'w')) Line 154: else: -- To view, visit http://gerrit.ovirt.org/27481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
