Dan Kenigsberg has submitted this change and it was merged. Change subject: correctness: Use new-style class when using @property ......................................................................
correctness: Use new-style class when using @property Commit 802e88c60c added a @property to few historic old-style classes. This works when reading the property value, but does not create a read-only property as it should. To have a read-only property, the class must be a new-style class (inherit from object). This patch converts clientIf, Disaptcher and HSM to new-style classes. For more info see: https://docs.python.org/2.6/library/functions.html#property Change-Id: I7ff98ff07832cb8236470071fcc85da3a0cfa2d2 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/28720 Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/clientIF.py M vdsm/storage/dispatcher.py M vdsm/storage/hsm.py 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ff98ff07832cb8236470071fcc85da3a0cfa2d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
