Francesco Romani has posted comments on this change. Change subject: tests: initial type checks for API responses ......................................................................
Patch Set 2: (1 comment) Nir, I'll amend the commit message to explain better what this patch is supposed to improve, and why it is useful http://gerrit.ovirt.org/#/c/28802/2/tests/vmApiTests.py File tests/vmApiTests.py: Line 63: isinstance > I think that rather should check for basestring, some values can be unicode good point, will change. -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
