Nir Soffer has posted comments on this change. Change subject: logs: improve VDSM logs human-readability ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28869/1/vdsm/logger.conf.in File vdsm/logger.conf.in: Line 66: [formatter_none] Line 67: format: %(message)s Line 68: Line 69: [formatter_long] Line 70: format: %(asctime)s %(levelname)s %(threadName)s: %(message)s (in function %(funcName)s %(pathname)s:%(lineno)d) > Can you explain the benefits of the suggested format string, beside persona - I also like the time first - every other logger does it, this is a must. - level name second +1, which type of message is very important - threadname +1 - whitespace instead of :: +1 - eaiser to read, easier to wrap lines - "in function" -1 - you want to add useless constant string on all logs?! - message should be kept last, because the invariant parts should be before the variant parts. - logger name was removed - sometimes this is useful, not sure about removing it. The original location sucks, should be at the start, near the level name. But generally the format string is not a good way to discuss this. Show us same logs lines in both old and new format. Line 71: Line 72: [formatter_sysform] Line 73: format= vdsm %(name)s %(levelname)s %(message)s Line 74: datefmt= -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches