Dan Kenigsberg has posted comments on this change. Change subject: virt: Avoid timeout log spam due to channel timeouts ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27627/1/vdsm/virt/vmchannels.py File vdsm/virt/vmchannels.py: Line 90: """ Line 91: now = time.time() Line 92: for (fileno, obj) in self._channels.items(): Line 93: if (now - obj['read_time']) >= self._timeout: Line 94: if not obj.get('timeout_seen', False): I think that the code could be cleaner if we make sure that 'timeout_seen' is always there (with an initial value of False). However, we already have this tristate for 'cooldown'. So it's your call, Vinzenz. Line 95: self.log.debug("Timeout on fileno %d.", fileno) Line 96: obj['timeout_seen'] = True Line 97: try: Line 98: obj['timeout_cb'](obj['opaque']) -- To view, visit http://gerrit.ovirt.org/27627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e868ce7c0ab28a9f7983887a097f760c3d0f69 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Gal Hammer <ghammer%[email protected]> Gerrit-Reviewer: Sven Kieske <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
