Barak Azulay has posted comments on this change. Change subject: fencing: Introduce getHostStatus API ......................................................................
Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28873/3/vdsm/API.py File vdsm/API.py: Line 1496: Line 1497: def stopMonitoringDomain(self, sdUUID): Line 1498: return self._irs.stopMonitoringDomain(sdUUID) Line 1499: Line 1500: def getHostStatus(self, hostId): I would rather at this stage this API will not be public. Saggi what do you think ? Line 1501: return self._irs.getHostStatus(hostId) Line 1502: Line 1503: def getLVMVolumeGroups(self, storageType=None): Line 1504: return self._irs.getVGList(storageType) http://gerrit.ovirt.org/#/c/28873/3/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3619: getHostStatus I saw the discussion on the name, getHostStatus is misleading anyway. This status represents the hostId lease status (locksppace in sanlock terminology). So It could be getHostLeaseStatus, but please don't use getHostStatus -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
