Dan Kenigsberg has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28817/3/vdsm/rpc/BindingXMLRPC.py File vdsm/rpc/BindingXMLRPC.py: Line 42: Line 43: class BindingXMLRPC(object): Line 44: def __init__(self, cif, log, host, port, last_client, default_bridge): Line 45: self.cif = cif Line 46: self._last_client = last_client > Dan, Tony can you help us how it should work? Up until now, we did not have the problem described by Nir - each client had its own thread, with its own threadLocal.client. Each response should report back from which network interface (and IP) it thinks it has originated. Line 47: self.threadLocal = threading.local() Line 48: self.log = log Line 49: self.serverIP = host Line 50: self.serverPort = port Line 292: Line 293: if getattr(self.threadLocal, Line 294: 'flowID', None) is not None: Line 295: fmt += " flowID [%s]" Line 296: logargs.append(self.threadLocal.flowID) > I haven't seen it in xmlrpc code so I have decided not to send it. please grep for threadLocal.flowID = self.headers.get(HTTP_HEADER_FLOWID) this header is used to facilitate debugging complex Engine/Vdsm interactions. Missing it in jsonrpc would be a regression. Line 297: Line 298: self.log.debug(fmt, *logargs) Line 299: Line 300: try: -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
