Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Removal of management_ip info in getCaps ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28993/1/vdsm/rpc/BindingXMLRPC.py File vdsm/rpc/BindingXMLRPC.py: Line 43: class BindingXMLRPC(object): Line 44: def __init__(self, cif, log, port, default_bridge): Line 45: self.cif = cif Line 46: self.log = log Line 47: self.serverPort = port > migration.py can get it from the config, there is no reason that migration Oh, I missed the usage of serverPort. I also forgot that migrationCreate works only over xmlrpc (who is tracking this?) (ack for dropping the needless args in a follow up) Line 48: self.defaultBridge = default_bridge Line 49: Line 50: self._enabled = False Line 51: self.server = self._createXMLRPCServer() -- To view, visit http://gerrit.ovirt.org/28993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5851a55995e7d1bb617cc958f8bfee7dfb994a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
