Francesco Romani has posted comments on this change. Change subject: vm: add optimizations for hyperv ......................................................................
Patch Set 5: (1 comment) explain the reason for self inflicted -1 http://gerrit.ovirt.org/#/c/27619/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 716: """ Line 717: Line 718: if (self.arch == caps.Architecture.X86_64 and Line 719: utils.tobool(self.conf.get('hypervEnable', 'false'))): Line 720: clockName = 'hypervclock' this is not available until libvirt 1.2.2. - and it is not in RHEL 6.5. Probably the best way forward is to add another boolean just for clock. Line 721: else: Line 722: clockName = 'rtc' Line 723: Line 724: m = XMLElement('clock', offset='variable', -- To view, visit http://gerrit.ovirt.org/27619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
