David Caro has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/29213/7/vdsm.spec.in File vdsm.spec.in: Line 19: # (or provide a command-line override) if they backport any patches that Line 20: # touch configure.ac or Makefile.am. Line 21: %{!?enable_autotools:%define enable_autotools 0} Line 22: Line 23: # Skip make check if we are running on el host > this comment only translate the following code to English. Better say *why* Done Line 24: %if ! 0%{?rhel} Line 25: %global with_check 1 Line 26: %endif Line 27: Line 96: BuildRequires: automake Line 97: BuildRequires: gettext-devel Line 98: BuildRequires: libtool Line 99: %endif Line 100: > please replace this with Sorry, are you talking about this patch and this line? Line 101: %if !0%{?rhel} Line 102: BuildRequires: pyflakes Line 103: BuildRequires: python-pep8 Line 104: %endif -- To view, visit http://gerrit.ovirt.org/29213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
