Michal Skrivanek has posted comments on this change. Change subject: vm: hyperv: initial windows hyperv support ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27619/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 705: Line 706: self._devices = XMLElement('devices') Line 707: self.dom.appendChild(self._devices) Line 708: Line 709: def _isHyperV(self): > I just want to make sure to not break PPC64. well, I'd prefer not to spread arch checks like plague and try to trust engine. We believe it is saying the right thing for all other devices, etc., and as long as the vdsm doesn't break and the outcome is only a failure in VM creation…. Line 710: return (self.arch == caps.Architecture.X86_64 and Line 711: utils.tobool(self.conf.get('hypervEnable', 'false'))) Line 712: Line 713: def appendClock(self): -- To view, visit http://gerrit.ovirt.org/27619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
