Federico Simoncelli has posted comments on this change. Change subject: detach: Support force detach on Storage Domains with old pools. ......................................................................
Patch Set 14: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/29042/14/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 747: # API which we want to drop in next version anyway. Line 748: # So to get the pool we use the fact that there can be only one Line 749: # pool, and get the host id from it. Line 750: if len(self.pools) > 1: Line 751: raise AssertionError("Multiple pools are not supported") I have no idea why this suddenly became so important. We just need an ID and we're getting it from the first pool if present. It's really not this method duty to warn about multiple pools. Line 752: try: Line 753: pool = self.pools.values()[0] Line 754: except IndexError: Line 755: raise se.StoragePoolNotConnected() -- To view, visit http://gerrit.ovirt.org/29042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
