Vinzenz Feenstra has posted comments on this change. Change subject: Added support for reporting the timezone and os info ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28940/3//COMMIT_MSG Commit Message: Line 6: Line 7: Added support for reporting the timezone and os info Line 8: Line 9: The guest agent reports now the timezone and more detailed Line 10: os information. This patch introduces the support for those > please refer the change in ga Done Line 11: new messages. Line 12: Line 13: Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Line 14: Guest-Agent-API-Version: 2 http://gerrit.ovirt.org/#/c/28940/3/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 253: self.effectiveApiVersion = _IMPLICIT_API_VERSION_ZERO Line 254: elif message == 'host-name': Line 255: self.guestInfo['guestName'] = args['name'] Line 256: elif message == 'os-version': Line 257: self.guestInfo['guestOs'] = args['version'] > so this is basically superseded by the os-info, right? Yes, but we have to support it due to backwards compatibility Line 258: elif message == 'os-info': Line 259: self.guestInfo['guestOsInfo'] = args Line 260: elif message == 'timezone': Line 261: self.guestInfo['guestTimezone'] = args -- To view, visit http://gerrit.ovirt.org/28940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
