Dan Kenigsberg has posted comments on this change. Change subject: vdsm: verifyingTransport testing ......................................................................
Patch Set 7: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28858/7/tests/sslTests.py File tests/sslTests.py: Line 64: def serve_forever(self): Line 65: try: Line 66: self.server.serve_forever() Line 67: except: Line 68: # we want to hide server side exception could you catch only the expected exceptions here? and if you keep the comment, please explain *why* we want to hide the errors. Line 69: pass Line 70: Line 71: def stop(self): Line 72: self.server.shutdown() Line 93: Line 94: class VerifyingTransportTests(TestCaseBase): Line 95: Line 96: def test_valid(self): Line 97: server = TestServer() I do not see Nir's comments acted upon - shouldn't they? Line 98: client = VerifingClient(server.port, KEY_FILE, CRT_FILE) Line 99: try: Line 100: self.assertEquals(client.add(2, 3), 5) Line 101: finally: -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
