Yoav Kleinberger has posted comments on this change. Change subject: multipath: Rescan also FC devices ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/27122/5/vdsm/storage/hba.py File vdsm/storage/hba.py: Line 29 Line 30 Line 31 Line 32 Line 33 FIBER_CHANNEL_HOST_MASK too many initialisms in our code already. Line 57: try: Line 58: with open(path, 'w') as f: Line 59: f.write('1') Line 60: except IOError as e: Line 61: logging.error("Error issuing lip: %s", e) include path in error message Line 62: Line 63: Line 64: def getiSCSIInitiators(): Line 65: """ http://gerrit.ovirt.org/#/c/27122/5/vdsm/storage/multipath.py File vdsm/storage/multipath.py: Line 101: Line 102: Should only be called from hsm._rescanDevices() Line 103: """ Line 104: Line 105: # First rescan iSCSI and FCP connections FCP -> Fiber Channel Line 106: iscsi.rescan() Line 107: supervdsm.getProxy().hbaRescan() Line 108: Line 109: # Now let multipath daemon pick up new devices -- To view, visit http://gerrit.ovirt.org/27122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7699504f9771232ee0b880f9c83a51fd5b90f40e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Elad Ben Aharon <eladba1...@gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
