Francesco Romani has posted comments on this change. Change subject: vm: extract a method to wait for migration ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28509/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3592: del self.conf['username'] Line 3593: self.saveState() Line 3594: self.log.debug("End of migration") Line 3595: Line 3596: def _waitForIncomingMigrationToComplete(self): > I mean, that the separation of responsibility between the calling waitForIn You are right, the readability of this code is made (IMHO a little) worse by this change. This is done because I'm trying to keep this patchset easily backportable. The real change which is needed to clean up properly is much bigger and deeper. Line 3597: timeout = config.getint('vars', 'migration_destination_timeout') Line 3598: self.log.debug("Waiting %s seconds for end of migration", timeout) Line 3599: self._incomingMigrationFinished.wait(timeout) Line 3600: -- To view, visit http://gerrit.ovirt.org/28509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic469814afc607951870f4171499cef958855fc54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
