Nir Soffer has posted comments on this change. Change subject: utils: Remove duplicate set non-blocking functions ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29413/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1142: def prependDefer(self, func, *args, **kwargs): Line 1143: self._finally.insert(0, (func, args, kwargs)) Line 1144: Line 1145: Line 1146: def setNonBlocking(fd): > +1 for using modern names for new functions. Please don't. I prefer names_with_underscores, but a module should have consistent api. The correct solution would be to rename all utils.py to underscores. Line 1147: if hasattr(fd, "fileno"): Line 1148: fd = fd.fileno() Line 1149: Line 1150: fl = fcntl.fcntl(fd, fcntl.F_GETFL) -- To view, visit http://gerrit.ovirt.org/29413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd242e8b437e485e45127d083c35957ccecf577 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
