Federico Simoncelli has posted comments on this change. Change subject: spec: move reconfigure logic from %postun to %post ......................................................................
Patch Set 1: Code-Review-1 (1 comment) The way to go is to be backward compatible with the old %postun commands. Question is if we want to support direct upgrades from 3.2 to 3.4: https://bugzilla.redhat.com/show_bug.cgi?id=1111935#c6 http://gerrit.ovirt.org/#/c/29364/1/vdsm.spec.in File vdsm.spec.in: Line 714: %{_bindir}/vdsm-tool sebool-config || : Line 715: # set the vdsm "secret" password for libvirt Line 716: %{_bindir}/vdsm-tool set-saslpasswd Line 717: Line 718: if [ "$1" -ge 1 ]; then All this logic needs to happen in %postun because during %post you have both packages installed at the same time (possibly causing unexpected glitches). Line 719: supervdsmd_start_required='no' Line 720: vdsmd_start_required='no' Line 721: Line 722: # Both vdsm and supervdsm should be managed here and must be restarted if -- To view, visit http://gerrit.ovirt.org/29364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I190ac484937ea794d69d9e14ff6ffd5d5d69cc00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
