Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: Cleanup imports ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29015/1/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 25: Line 26: import misc Line 27: from sdc import sdCache Line 28: from vdsm import utils Line 29: from vdsm.config import config It may be worth checking pep 328 for relative imports since we're at it. Line 30: Line 31: Line 32: class DomainMonitorStatus(object): Line 33: __slots__ = ( -- To view, visit http://gerrit.ovirt.org/29015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff024da4c259e8976e6248b5b10e1bb55128312c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
