Nir Soffer has posted comments on this change. Change subject: vdsm: Missing hostId parameter on reconstructMaster verb ......................................................................
Patch Set 1: Code-Review+1 (2 comments) Just need more detailed commit message explaining the messs. http://gerrit.ovirt.org/#/c/29510/1//COMMIT_MSG Commit Message: Line 6: Line 7: vdsm: Missing hostId parameter on reconstructMaster verb Line 8: Line 9: Json schema was not consistent with API.py and there was missing Line 10: hostId parameter. Please describe that schema document the classes in API and the argument order is different then in the xmlrpc, which is *not* documented by the schema. Line 11: Line 12: Line 13: Change-Id: I0695a21601b8f0765bc24c3cf273f1ba161a40a9 Line 14: Signed-off-by: pkliczewski <[email protected]> http://gerrit.ovirt.org/#/c/29510/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 5234: # @StoragePool.reconstructMaster: Line 5235: # Line 5236: # Recover a Storage Pool by reconstructing its Storage Domains. Line 5237: # Line 5238: # @storagepoolID: The UUID of the Storage Pool > As I can see in API.py: You are right, our code is more horrible that I thought. Line 5239: # Line 5240: # @hostId: Host Id used by San lock. Line 5241: # Line 5242: # @name: A human-readable name for the Storage Pool -- To view, visit http://gerrit.ovirt.org/29510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0695a21601b8f0765bc24c3cf273f1ba161a40a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
