Dan Kenigsberg has posted comments on this change. Change subject: HostStats: stop storing list of host ifids and speeds ......................................................................
Patch Set 2: Verified+1 Code-Review+2 (1 comment) verified with the entire topic branch http://gerrit.ovirt.org/#/c/29470/2/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 100: return '0' Line 101: return 'up' if flags & ethtool.IFF_RUNNING else 'down' Line 102: Line 103: def __init__(self, link): Line 104: ifid = link.name > I'm being picky, I now. But let's have a future patch that changes this var Agreed. And remaining references to ifrate should be changed to "speed". Line 105: self.rx = self.readIfaceStat(ifid, 'rx_bytes') Line 106: self.tx = self.readIfaceStat(ifid, 'tx_bytes') Line 107: self.rxDropped = self.readIfaceStat(ifid, 'rx_dropped') Line 108: self.txDropped = self.readIfaceStat(ifid, 'tx_dropped') -- To view, visit http://gerrit.ovirt.org/29470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad0605c910564a8a7072484301c51b4b8a325751 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
