Francesco Romani has posted comments on this change. Change subject: threadpool: docs: add design notes ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29190/4/lib/threadpool/README.rst File lib/threadpool/README.rst: Line 49: Line 50: The countermeasures implemented in WatchedThreadPool are the following. Line 51: Line 52: 1. each worker takes a task exclusively. Line 53: each task must be taken exactly by one worker and exactly once for each > I did not suggest to retry blocked calls - retrying task is not the respons OK, I think I used a poor wording and highlighted a something is already guaranteed by all the thread pools. Will rephrase and explain better in the README. Line 54: request. Each task is consumed by the first worker thread which takes it. Line 55: Thus, at any given time at most one worker thread can get stuck Line 56: on an unresponsive task. Line 57: Periodic task are implemented by letting a worker thread to produce a clone -- To view, visit http://gerrit.ovirt.org/29190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400799e300f5d012dae5d158c4379fe57db1bd37 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
