Dan Kenigsberg has posted comments on this change. Change subject: migration: deprecate != 'online' migrations ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29555/2/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 61: self.log = vm.log Line 62: self._vm = vm Line 63: self._dst = dst Line 64: self._mode = mode Line 65: if method != METHOD_ONLINE: Sorry for not being clear later, but I was looking for something more brutal. We cannot change the API just now, but we can safely drop any mention of METHOD_ONLINE, the method argument, and the _method member. Let's justify the "janitorial" topic! Line 66: self.log.warning('migration method %s is deprecated', method) Line 67: self._method = method Line 68: self._dstparams = dstparams Line 69: self._machineParams = {} -- To view, visit http://gerrit.ovirt.org/29555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40a9c9ab26d0bb4dd9e3a2ff449b318fa0e96f49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
