Dan Kenigsberg has posted comments on this change. Change subject: netlink: make the scope string stable across libnl1-3 ......................................................................
Patch Set 1: Code-Review-1 (1 comment) -1 for visibility only http://gerrit.ovirt.org/#/c/29598/1/lib/vdsm/netlink/__init__.py File lib/vdsm/netlink/__init__.py: Line 104: """Returns the textual scope representation of the numerical id""" Line 105: scope = (c_char * CHARBUFFSIZE)() Line 106: scope = _rtnl_scope2str(scope_num, scope, sizeof(scope)) Line 107: # libnl1 reports 'universe' instead of 'global' Line 108: return scope if scope != 'universe' else 'global' I prefer positive conditions: return 'global' if scope == 'universe' else scope would you not agree? Line 109: Line 110: # C function prototypes Line 111: # http://docs.python.org/2/library/ctypes.html#function-prototypes Line 112: # This helps ctypes know the calling conventions it should use to communicate -- To view, visit http://gerrit.ovirt.org/29598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I700ba3d0997a5c829c460753a300d4529aae2a61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
