Dan Kenigsberg has posted comments on this change. Change subject: Add soft dependency on libvirt's metadata support to stats collector ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/29504/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 324: libvirt.VIR_ERR_NO_DOMAIN_METADATA)): Line 325: # Non-existing VM and no metadata block are expected Line 326: # conditions and no reasons for concern here. Line 327: # All other errors should be reported. Line 328: self._log.warn("Failed to retrieve QoS metadata") > add e to the log line? do you mean exc_info=True? Thats only make things wo Yes, I love tracebacks. Users want their peace of mind, but I want to tell them the whole unhappy truth. However, in this case, I understand why traceback is to be frowned upon. Hence I ask to add ('bla %s', e) to the log line. Without it, we cannot tell which VIR_ERR_ we encountered. Line 329: Line 330: if metadataCpuLimit: Line 331: metadataCpuLimitXML = _domParseStr(metadataCpuLimit) Line 332: nodeList = \ -- To view, visit http://gerrit.ovirt.org/29504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d38d3aff3bda42dfaafa87bab9fa5983fb4b9a8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
