Francesco Romani has posted comments on this change. Change subject: Refactor XMLElement to virt.utils ......................................................................
Patch Set 3: On one hand I'd like to avoid to move this code twice, once temporarily into utils (where it fits poorly, but right now I concur there is not better place right now). On the other hand I don't want to waste time and effort on those things, especially since both patches just moves code around. So I split my http://gerrit.ovirt.org/#/c/26855/4 in smaller pieces. Now 26855 does quite the same of this one, but put code in more appropriate (for medium/long term) places. The only thing debatable about 26855 is the name of the new module. If we can agree on the name quickly enough, I'm still to have 26855 in and save some work in the long run. Otherwise let's take the long route and have this in first. -- To view, visit http://gerrit.ovirt.org/29630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74528a597ace8148adbb0295a810ba7972b1270c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
