Nir Soffer has posted comments on this change. Change subject: tests: improve bounds for iscsi test ......................................................................
Patch Set 1: Code-Review-1 (2 comments) Unexplained change, using way too low time interval. http://gerrit.ovirt.org/#/c/29769/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-07-09 16:34:55 +0300 Line 6: Line 7: tests: improve bounds for iscsi test Line 8: Line 9: the previous bound in testSlow was unnecessarily generous. Why? How the change improve the test? What are you trying to achieve? Line 10: Line 11: Change-Id: Ie8e0753e6716fa193e0c5afde38c5a796896474e Line 12: Bug-Url: https://bugzilla.redhat.com/?????? http://gerrit.ovirt.org/#/c/29769/1/tests/iscsiTests.py File tests/iscsiTests.py: Line 75: iscsi.rescan(2, 4) Line 76: Line 77: def testSlow(self): Line 78: self._timeout = 60 Line 79: EMPIRICAL_SLACK = 0.01 Using any interval less then 0.1 second is too fast for tests, specially in our overloaded CI. If we want to wait for event up to some timeout, but don't want to wait for the entire timeout, use threading.Event. Line 80: with self.assertMaxDuration(2 + EMPIRICAL_SLACK): -- To view, visit http://gerrit.ovirt.org/29769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8e0753e6716fa193e0c5afde38c5a796896474e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
