Francesco Romani has posted comments on this change. Change subject: Add API.VM.getIoTunePolicy ......................................................................
Patch Set 20: Code-Review-1 (1 comment) Possible incoherency between Bridge.py and the API schema. Other than that, looks OK. -1 for visibility only. http://gerrit.ovirt.org/#/c/28896/20/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 409: 'VM_mergeStatus': {'ret': 'mergeStatus'}, Line 410: 'VM_migrationCreate': {'ret': VM_migrationCreate_Ret}, Line 411: 'VM_setNumberOfCpus': {'ret': 'vmList'}, Line 412: 'VM_getIoTunePolicy': {'ret': 'ioTunePolicyList'}, Line 413: 'Volume_copy': {'ret': 'uuid'}, But in the schema the return value is 'VmDiskDeviceTuneParams', is this correct? Line 414: 'Volume_create': {'ret': 'uuid'}, Line 415: 'Volume_delete': {'ret': 'uuid'}, Line 416: 'Volume_getInfo': {'ret': 'info'}, Line 417: 'Volume_getPath': {'ret': 'path'}, -- To view, visit http://gerrit.ovirt.org/28896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7983d91fe4b90c5b85c986c2b5a9a1931cfdc42 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
