Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: remove Link cli parser
......................................................................
Patch Set 1: Verified+1
Passed the functional tests and since the code was just on the flows there:
toniel602 tests (ad7722e) # ./run_tests_local.sh -x
functional/networkTests.py
NetworkTest
testAddDelBondedNetwork(kwargs=False) ddOK
testAddDelBondedNetwork(kwargs=True) OK
testAddDelNetwork(kwargs=False) OK
testAddDelNetwork(kwargs=True) OK
testAddNetworkBondWithManyVlans(kwargs=False) OK
testAddNetworkBondWithManyVlans(kwargs=True) OK
testAddNetworkManyVlans(kwargs=False) OK
testAddNetworkManyVlans(kwargs=True) OK
testAddNetworkVlan(kwargs=False) OK
testAddNetworkVlan(kwargs=True) OK
testAddNetworkVlanBond(kwargs=False) OK
testAddNetworkVlanBond(kwargs=True) OK
testAddVlanedBridgeless OK
testAddVlanedBridgeless_oneCommand OK
testAfterNetworkSetupHook OK
testBeforeNetworkSetupHook OK
testBondHwAddress(kwargs=False) OK
testBondHwAddress(kwargs=True) OK
testBrokenBridgelessNetReplacement OK
testDelNetworkBondAccumulation OK
testDelNetworkWithMTU(kwargs=False) OK
testDelNetworkWithMTU(kwargs=True) OK
testDelWithoutAdd(kwargs=False) OK
testDelWithoutAdd(kwargs=True) OK
testDhclientLeases(kwargs='default') OK
testDhclientLeases(kwargs='local') OK
testEditWithoutAdd(kwargs=False) OK
testEditWithoutAdd(kwargs=True) OK
testFailWithInvalidBondingName(kwargs=False) OK
testFailWithInvalidBondingName(kwargs=True) OK
testFailWithInvalidBridgeName OK
testFailWithInvalidIpConfig OK
testFailWithInvalidNic(kwargs=False) OK
testFailWithInvalidNic(kwargs=True) OK
testFailWithInvalidParams(kwargs=False) OK
testFailWithInvalidParams(kwargs=True) OK
testGetRouteDeviceTo OK
testHonorBlockingDhcp OK
testIPv6ConfigNetwork OK
testIpLinkWrapper dOK
testLegacyBonds OK
testLowerMtuDoesNotOverride OK
testNoBridgeLeftovers OK
testQosNetwork OK
testReconfigureBrNetWithVanishedPort OK
testRedefineBondedNetworkIPs OK
testReorderBondingOptions(kwargs=False) OK
testReorderBondingOptions(kwargs=True) OK
testRouteExists OK
testRuleExists OK
testSafeNetworkConfig(kwargs=False) OK
testSafeNetworkConfig(kwargs=True) OK
testSetupNetworksAddBadParams(bridged=False) OK
testSetupNetworksAddBadParams(bridged=True) OK
testSetupNetworksAddBondWithManyVlans(kwargs=False) OK
testSetupNetworksAddBondWithManyVlans(kwargs=True) OK
testSetupNetworksAddDelBondedNetwork(kwargs=False) OK
testSetupNetworksAddDelBondedNetwork(kwargs=True) OK
testSetupNetworksAddDelDhcp(kwargs=False) OK
testSetupNetworksAddDelDhcp(kwargs=True) OK
testSetupNetworksAddManyVlans(kwargs=False) OK
testSetupNetworksAddManyVlans(kwargs=True) OK
testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK
testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK
testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK
testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK
testSetupNetworksAddOverExistingBond(kwargs=False) OK
testSetupNetworksAddOverExistingBond(kwargs=True) OK
testSetupNetworksAddVlan(kwargs=False) OK
testSetupNetworksAddVlan(kwargs=True) SKIP: This
test is known to break until initscripts-9.03.41-1.el6 is released to fix
https://bugzilla.redhat.com/1086897
testSetupNetworksConvertVlanNetBridgeness OK
testSetupNetworksDelOneOfBondNets
testAddNetworkVlan(kwargs=True) OK
testAddNetworkVlanBond(kwargs=False) OK
testAddNetworkVlanBond(kwargs=True) OK
testAddVlanedBridgeless OK
testAddVlanedBridgeless_oneCommand OK
testAfterNetworkSetupHook OK
testBeforeNetworkSetupHook OK
testBondHwAddress(kwargs=False) OK
testBondHwAddress(kwargs=True) OK
testBrokenBridgelessNetReplacement OK
testDelNetworkBondAccumulation OK
testDelNetworkWithMTU(kwargs=False) OK
testDelNetworkWithMTU(kwargs=True) OK
testDelWithoutAdd(kwargs=False) OK
testDelWithoutAdd(kwargs=True) OK
testDhclientLeases(kwargs='default') OK
testDhclientLeases(kwargs='local') OK
testEditWithoutAdd(kwargs=False) OK
testEditWithoutAdd(kwargs=True) OK
testFailWithInvalidBondingName(kwargs=False) OK
testFailWithInvalidBondingName(kwargs=True) OK
testFailWithInvalidBridgeName OK
testFailWithInvalidIpConfig OK
testFailWithInvalidNic(kwargs=False) OK
testFailWithInvalidNic(kwargs=True) OK
testFailWithInvalidParams(kwargs=False) OK
testFailWithInvalidParams(kwargs=True) OK
testGetRouteDeviceTo OK
testHonorBlockingDhcp OK
testIPv6ConfigNetwork OK
testIpLinkWrapper dOK
testLegacyBonds OK
testLowerMtuDoesNotOverride OK
testNoBridgeLeftovers OK
testQosNetwork OK
testReconfigureBrNetWithVanishedPort OK
testRedefineBondedNetworkIPs OK
testReorderBondingOptions(kwargs=False) OK
testReorderBondingOptions(kwargs=True) OK
testRouteExists OK
testRuleExists OK
testSafeNetworkConfig(kwargs=False) OK
testSafeNetworkConfig(kwargs=True) OK
testSetupNetworksAddBadParams(bridged=False) OK
testSetupNetworksAddBadParams(bridged=True) OK
testSetupNetworksAddBondWithManyVlans(kwargs=False) OK
testSetupNetworksAddBondWithManyVlans(kwargs=True) OK
testSetupNetworksAddDelBondedNetwork(kwargs=False) OK
testSetupNetworksAddDelBondedNetwork(kwargs=True) OK
testSetupNetworksAddDelDhcp(kwargs=False) OK
testSetupNetworksAddDelDhcp(kwargs=True) OK
testSetupNetworksAddManyVlans(kwargs=False) OK
testSetupNetworksAddManyVlans(kwargs=True) OK
testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK
testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK
testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK
testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK
testSetupNetworksAddOverExistingBond(kwargs=False) OK
testSetupNetworksAddOverExistingBond(kwargs=True) OK
testSetupNetworksAddVlan(kwargs=False) OK
testSetupNetworksAddVlan(kwargs=True) SKIP: This
test is known to break until initscripts-9.03.41-1.el6 is released to fix
https://bugzilla.redhat.com/1086897
testSetupNetworksConvertVlanNetBridgeness OK
testSetupNetworksDelOneOfBondNets OK
testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=False)OK
testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=True)OK
testSetupNetworksMtus(kwargs=False) OK
testSetupNetworksMtus(kwargs=True) OK
testSetupNetworksMultiMTUsOverBond(kwargs=False) OK
testSetupNetworksMultiMTUsOverBond(kwargs=True) OK
testSetupNetworksMultiMTUsOverNic(kwargs=False) OK
testSetupNetworksMultiMTUsOverNic(kwargs=True) OK
testSetupNetworksNetCompatibilityBondSingleBridge OK
testSetupNetworksNetCompatibilityBondSingleBridgeless OK
testSetupNetworksNetCompatibilityNicSingleBridge OK
testSetupNetworksNetCompatibilityNicSingleBridgeless OK
testSetupNetworksNicless OK
testSetupNetworksNiclessBridgeless OK
testSetupNetworksOverDhcpIface OK
testSetupNetworksResizeBond(kwargs=False) OK
testSetupNetworksResizeBond(kwargs=True) OK
testSetupNetworksStableBond(kwargs=False) OK
testSetupNetworksStableBond(kwargs=True) OK
testStaticSourceRouting(kwargs=False) OK
testStaticSourceRouting(kwargs=True) OK
testTwiceAdd(kwargs=False) OK
testTwiceAdd(kwargs=True) OK
testVolatileConfig(kwargs=False) OK
testVolatileConfig(kwargs=True) OK
----------------------------------------------------------------------
Ran 97 tests in 1288.017s
OK (SKIP=1)
toniel602 tests (ad7722e) #
This and the previous patch can be deemed as verified.
--
To view, visit http://gerrit.ovirt.org/29727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecffa05d8e6d6da3df57f0eb44f37465c87f93e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
