Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: revived forgotten test ......................................................................
tests: revived forgotten test It appears that the original author meant for the writeLargeData to be a test, but forgot the `test' prefix. Moreover, previously the test asserted data>4096, where data is a string, which in python is always True. I simplified it a bit, and removed the trivial assertion. Change-Id: I1a847e83046ea12596076fabaa42baba6939e1cd Signed-off-by: Yoav Kleinberger <[email protected]> Reviewed-on: http://gerrit.ovirt.org/29780 Reviewed-by: Vered Volansky <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/miscTests.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Yoav Kleinberger: Verified Dan Kenigsberg: Looks good to me, approved Vered Volansky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a847e83046ea12596076fabaa42baba6939e1cd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
