Martin Sivák has posted comments on this change. Change subject: Add IO tunables support to updateVmPolicy ......................................................................
Patch Set 24: (2 comments) http://gerrit.ovirt.org/#/c/28715/24/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 7575: # Line 7576: # Since: 4.15.0 Line 7577: ## Line 7578: {'command': {'class': 'VM', 'name': 'updateVmPolicy'}, Line 7579: 'data': {'vmID': 'UUID', '*vcpuLimit': 'int', '*ioTune': ['VmDiskDeviceTuneLimits']}} > I do not see corresponding change in API.py. Whenever you change schema ple No change is needed there. This method gets all arguments using params dictionary so everything should be ok. http://gerrit.ovirt.org/#/c/28715/24/vdsm/virt/vmtune.py File vdsm/virt/vmtune.py: Line 26: Line 27: log = logging.getLogger(__name__) Line 28: Line 29: Line 30: def ioTuneValuesToDom(values, dom): > We've agreed that new functions, certainly in new modules, should have mode I would prefer to do that in another patch if that is ok with you, it will affect almost all of the outstanding patches in this series. Line 31: """ Line 32: Create a DOM representation of the passed iotune values and Line 33: attach it to the dom object in the form of nodes. Line 34: -- To view, visit http://gerrit.ovirt.org/28715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ed108fbb2bf9d9af80577b2905242bf9f8c4221 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
