Francesco Romani has posted comments on this change. Change subject: WIP DRAFT virt: scalable sampling ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29977/1/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 384: return self._sampleTime Line 385: Line 386: def start(self): Line 387: self._run = True Line 388: _Scheduler(self._statfunc.interval, self._onSchedule) > Did you mean: Yes :) Line 389: Line 390: def stop(self): Line 391: self._run = False Line 392: Line 418: else: Line 419: self._do_sampling() Line 420: self._vm._timeoutExperienced(False) Line 421: Line 422: self._schedule(self._statfunc.interval, self.onSchedule) > It will be nice idea to implement this Is just rescheduling: _Scheduler.schedule(self._statfunc.interval, self.onSchedule). Let me amend this. Line 423: Line 424: def _do_sampling(self): Line 425: with self._in_progress(): Line 426: try: -- To view, visit http://gerrit.ovirt.org/29977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f54990b2114cbe931f64d6207192d1f6c6a3799 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
