Yoav Kleinberger has posted comments on this change. Change subject: tests: Add a live merge functional test ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29824/1/tests/functional/utils.py File tests/functional/utils.py: Line 238: result = self.vdscli.getVolumeInfo(sdId, spId, imgId, volId) Line 239: return result['status']['code'], result['status']['message'],\ Line 240: result['info'] Line 241: Line 242: def createVolume(self, sdId, spId, imgId, size, volFormat, preallocate, OK Nir, I agree. Line 243: diskType, volId, desc, baseImgId, baseVolId): Line 244: result = self.vdscli.createVolume(sdId, spId, imgId, size, volFormat, Line 245: preallocate, diskType, volId, desc, Line 246: baseImgId, baseVolId) http://gerrit.ovirt.org/#/c/29824/1/tests/functional/virtTests.py File tests/functional/virtTests.py: Line 552: jobId) Line 553: jobIds.append(jobId) Line 554: self._waitBlockJobs(vmId, jobIds) Line 555: actual = self._getVolumeChains(vmId) Line 556: self.assertEquals(chains, actual) > The chance that you can sneak into the machines running this test and inst No one is going to mock VDSM. My point is that this doesn't really check what it should. On the other hand, all the other functional tests are the same. Waiting to hear what Adam has to say. -- To view, visit http://gerrit.ovirt.org/29824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd5a2f7eedaef9e90981256de66fc3ed21658e89 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
