Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Separate test runner from test library ......................................................................
tests: Separate test runner from test library The test runner was used both as a script and as a library for testing utitilies. This cause the module to be imported twice, performing various hacks twice. Runnning pthreading.monkey_patch() twice fails with upstream pthreading, which ensure that monkey pataching is not too late. The check in pthreading should be fixed, but it expose the problem in the testrunner. This separate the library code from the script realted code and hacks that must run once in the context of the test runner script, fixing the double invocation of pthreading.monkey_patch(). Change-Id: I9aa145f929e27699982a15a662269f2a7b3cdfc3 Bug-Url: https://bugzilla.redhat.com/1119172 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/30022 Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Yoav Kleinberger <yklei...@redhat.com> Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Martin Sivák <msi...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/Makefile.am M tests/alignmentScanTests.py M tests/blocksdTests.py M tests/bridgeTests.py M tests/cPopenTests.py M tests/capsTests.py M tests/clientifTests.py M tests/configNetworkTests.py M tests/crossImportsTests.py.in M tests/fileUtilTests.py M tests/fileVolumeTests.py M tests/functional/momTests.py M tests/functional/networkTests.py M tests/functional/sosPluginTests.py M tests/functional/storageTests.py M tests/functional/supervdsmFuncTests.py M tests/functional/virtTests.py M tests/fuserTests.py M tests/getAllVolumesTests.py M tests/gluster_cli_tests.py M tests/guestagentTests.py M tests/hooksTests.py M tests/ipwrapperTests.py M tests/iscsiTests.py M tests/jsonRpcTests.py M tests/ksmTests.py M tests/libvirtconnectionTests.py M tests/lsblkTests.py M tests/lvmTests.py M tests/main.py M tests/md_utils_tests.py M tests/miscTests.py M tests/mkimageTests.py M tests/monkeypatchTests.py M tests/mountTests.py M tests/netconfTests.py M tests/netconfpersistenceTests.py M tests/netinfoTests.py M tests/netmodelsTests.py M tests/numaUtilsTests.py M tests/outOfProcessTests.py M tests/parted_utils_tests.py M tests/permutationTests.py M tests/persistentDictTests.py M tests/profileTests.py M tests/remoteFileHandlerTests.py M tests/resourceManagerTests.py M tests/samplingTests.py M tests/schemaTests.py M tests/securableTests.py M tests/sourceroutingTests.py M tests/sslTests.py M tests/storageMailboxTests.py M tests/tcTests.py A tests/testlib.py R tests/testlibTests.py M tests/testrunner.py M tests/transportWrapperTests.py M tests/utilsTests.py M tests/vdsClientTests.py M tests/vmApiTests.py M tests/vmTests.py M tests/volumeTests.py 63 files changed, 452 insertions(+), 430 deletions(-) Approvals: Nir Soffer: Verified Martin Sivák: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Yoav Kleinberger: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aa145f929e27699982a15a662269f2a7b3cdfc3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
