Vinzenz Feenstra has posted comments on this change. Change subject: Degrading epoll errors in vmchannels to log level INFO ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30141/1/vdsm/virt/vmchannels.py File vdsm/virt/vmchannels.py: Line 55: if fileno in self._channels: Line 56: reconnect = True Line 57: else: Line 58: self.log.debug("Received %.08X. On fd removed by epoll.", Line 59: event) > Maybe this then should be upgraded to 'error'? What happens when we are not Actually this is not an error either. It won't cause harm to the inner workings. If this one happens, we cannot reconnect anyway since we're not tracking this fd anymore. (since it's not in self._channels) This is a log message for post mortem checks to the logs if this happens when a customer/user had this issue. However this should occur very rarely, if at all now. Line 60: elif (event & select.EPOLLIN): Line 61: obj = self._channels.get(fileno, None) Line 62: if obj: Line 63: obj['reconnects'] = 0 -- To view, visit http://gerrit.ovirt.org/30141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0099fb39a6261e2339c12ae25ea16f32bff1a55f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
