Dan Kenigsberg has posted comments on this change. Change subject: virt: xml: add function to iterate over devices ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29698/3/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 22: import xml.dom Line 23: import xml.dom.minidom Line 24: Line 25: Line 26: def all_devices(domXML): why is the "all_" prefix? Particularly when this function does not report *all* devices, but only those with alias. Line 27: domObj = xml.dom.minidom.parseString(domXML) Line 28: devices = domObj.childNodes[0].getElementsByTagName('devices')[0] Line 29: Line 30: for deviceXML in devices.childNodes: -- To view, visit http://gerrit.ovirt.org/29698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I883969de4ff8a992303183c92874f09ee073f466 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
