Michal Skrivanek has posted comments on this change. Change subject: Live Merge: fix race between libvirt event and vm stats ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29309/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5456: jobs = {} Line 5457: # We need to take the jobs lock here to ensure that we don't race with Line 5458: # another call to merge() where the job has been recorded but not yet Line 5459: # started. Line 5460: with self._jobsLock: > In that case it's no problem (but please see my updated livemerge topic bra so cannot this be used as a general solution to timing? - so you don't have to do this first stat cycle here - I think the elimination of the lock is worth it Line 5461: for job in self.conf['_blockJobs'].values()[:]: Line 5462: jobID = job['jobID'] Line 5463: drive = self._findDriveByUUIDs(job['disk']) Line 5464: -- To view, visit http://gerrit.ovirt.org/29309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0314a39428419bb21bc579f07a92227d5a7acff Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
